Support defining predicates using #[thrust::predicate] attribute with fn statements#23
Merged
Merged
Conversation
coord-e
approved these changes
Jan 23, 2026
| pub struct UserDefinedPredDef { | ||
| symbol: UserDefinedPred, | ||
| sig: UserDefinedPredSig, | ||
| body: RawCommand, |
Owner
There was a problem hiding this comment.
I think it's natural to use a String directly here, as RawCommand shouldn't serve a different purpose
Suggested change
| body: RawCommand, | |
| body: String, |
Collaborator
Author
|
I added more details to the PR description. |
…defintions in .smt2 file
coeff-aij
commented
Jan 26, 2026
Collaborator
Author
There was a problem hiding this comment.
I think raw‑command definitions and user‑defined predicates should be emitted before the datatype declarations in the generated .smt2 file.
The reason is that raw commands and predicates written by users may refer to previously declared datatypes(ex. access fieleds of structs), whereas datatype definitions emmitted by Thrust will not refer to those commands or predicates.
coord-e
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature recognizes functions annotated with
#[thrust::predicate]as predicates and inserts correspondingdefine-fundefinitions—derived from their names and arguments—into the.smt2file. The first string literal that appears in a function's body is inserted as the predicate body.Compared with
#![thrust::raw_command], Thrust can assign a predicate name automatically and later leverage that name to connect the predicate to relevant traits(for example,SomeTrait::pred->(define-fun some_trait_pred)).If a user writes the following:
the appropriate definitions are inserted into the .smt2 file.